[igt-dev] [PATCH v2 4/4] test/kms_atomic: Skip plane overlay test for amdgpu

Rodrigo Siqueira Rodrigo.Siqueira at amd.com
Wed Aug 25 14:36:58 UTC 2021


Currently, amdgpu does not support an overlay strategy. As a result,
plane_overlay fails on amdgpu; since this is a driver limitation, this
commit skips the overlay test for amdgpu.

Changes since V1:
- Improve skip message

Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Nicholas Choi <Nicholas.Choi at amd.com>
Cc: Sean Paul <seanpaul at chromium.org>
Cc: Mark Yacoub <markyacoub at chromium.org>
Cc: Melissa Wen <melissa.srw at gmail.com>
Cc: Arkadiusz Hiler <arek at hiler.eu>
Cc: Petri Latvala <petri.latvala at intel.com>
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
---
 tests/kms_atomic.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 1e1bee4d..862ccaa9 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -501,6 +501,13 @@ static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *p
 	uint32_t w = mode->hdisplay / 2;
 	uint32_t h = mode->vdisplay / 2;
 
+	/* On AMD, with hardware cursor, overlay plane must fully cover
+	 * the primary plane (underlay). AMD does not support this test
+	 * scenario
+	 */
+	igt_require_f(!is_amdgpu_device(output->display->drm_fd),
+		      "Overlay must fully cover the primary plane on AMD\n");
+
 	igt_require(format != 0);
 
 	igt_create_pattern_fb(pipe->display->drm_fd, w, h,
-- 
2.25.1



More information about the igt-dev mailing list