[igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU

[Yin, Tianci (Rico)]

[AMD Official Use Only]

Hi Siqueira, Rodrigo,

Would you please help reviewing this patch?

Thank you very much!
Rico
________________________________
From: Tianci Yin <tianci.yin at amd.com>
Sent: Wednesday, August 25, 2021 15:47
To: igt-dev at lists.freedesktop.org <igt-dev at lists.freedesktop.org>; Petri Latvala <petri.latvala at intel.com>; Arkadiusz Hiler <arek at hiler.eu>
Cc: Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; Mark Yacoub <markyacoub at google.com>; Wentland, Harry <Harry.Wentland at amd.com>; Choi, Nicholas <Nicholas.Choi at amd.com>; Yin, Tianci (Rico) <Tianci.Yin at amd.com>
Subject: [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU

From: "Tianci.Yin" <tianci.yin at amd.com>

[why]
For subtest legacy-setmode and atomic-setmode, fb buffer is
unbinded from plane by block_plane(), then igt_display_commit2()
will trigger a dmesg warning message in drm_atomic_helper_commit(),
since for block commit, drm will wait fences that represents
finishing fb writing, when it find this fence has no accompanying
fb, it gives out a warning.

[how]
Just remove igt_plane_set_fb() from block_plane() to retain
the fb binding with plane.
Verified on AMD Radeon Pro W5500 and Intel UHD Graphics 630
(inside i7-9700K), both pass.

Signed-off-by: Tianci.Yin <tianci.yin at amd.com>
---
 tests/kms_atomic_interruptible.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
index 0a127921..03980d6e 100644
--- a/tests/kms_atomic_interruptible.c
+++ b/tests/kms_atomic_interruptible.c
@@ -49,7 +49,6 @@ static int block_plane(igt_display_t *display, igt_output_t *output, enum plane_

                 if (test_type == test_legacy_modeset || test_type == test_atomic_modeset) {
                         igt_output_set_pipe(output, PIPE_NONE);
-                       igt_plane_set_fb(plane, NULL);
                 }
                 igt_plane_set_fence_fd(plane, sw_sync_timeline_create_fence(timeline, 1));

--
2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20210826/8ec98024/attachment-0001.htm>