[igt-dev] [i-g-t V2] tests/kms_setmode: Handle unsupported modes for invalid crtc test

Tejas Upadhyay tejaskumarx.surendrakumar.upadhyay at intel.com
Fri Aug 27 05:23:49 UTC 2021


Unsupported modes in crtc need to return proper error in order
to report back that applied config was failed or not. Thus
previously added ENOENT error but later decided to remove
crtc_supports_mode check which is also possible solution.

Test affected (fail -> pass after change) :
igt at kms_setmode@invalid-clone-single-[crtc|crtc-stealing]

invalid-clone-single-crtc-stealing still fails which is not
related and will be handled with different follow up patch.

Changes since V1:
	- Replaced previous logic with crtc_supports_mode check removal

Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay at intel.com>
---
 tests/kms_setmode.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 89220b83..80665204 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -569,9 +569,6 @@ int __test_crtc_config(struct crtc_config *crtcs, int crtc_count,
 	for (int i = 0; i < crtc->cconfs->connector->count_modes; i++) {
 		uint32_t *ids;
 
-		if (!crtc_supports_mode(crtc, &crtc->cconfs->connector->modes[i]))
-			continue;
-
 		crtc->mode = crtc->cconfs->connector->modes[i];
 
 		get_crtc_config_str(crtc, str_buf[base], sizeof(str_buf[base]));
-- 
2.31.1



More information about the igt-dev mailing list