[igt-dev] [i-g-t] tests/i915/exec_balancer: Added Skip Guc Submission
Radoslaw Szwichtenberg
radoslaw.szwichtenberg at intel.com
Wed Dec 1 11:36:58 UTC 2021
On 01/12/2021 10:46, Tvrtko Ursulin wrote:
>
> On 30/11/2021 16:48, Matthew Brost wrote:
>>
>> IMO this fix is 100% correct as this is a known, tracked issue. It was
>> agreed upon (arch, i915, GuC team) that we just skip these tests with
>> GuC submission.
This does not look like a fix to me - you just disable test to hide the
result. If this issue is recorded with a bug, is tracked - why cant we
just let this test fail till we get this issue fixed?
>
> I915 team is here on upstream as well.
>
> Record those acks publicly would be my ask. Unless some security by
> obscurity is happening here? Until then from me it is a soft nack to
> keep disabling tests which show genuine weaknesses in GuC mode. Soft
> until we get a public record of exactly what is broken and in what
> circumstances, acked by architects publicly as you say they acked it
> somewhere. Commit message devoid of detail is not good enough.
This should be most probably documented in the bug, right? Here we
should just keep the test as is till the issue is fixed. I don't see how
docummenting an issue would enable us to just disable the test.
Radek
More information about the igt-dev
mailing list