[igt-dev] [PATCH i-g-t] lib/i915/intel_memory_region: Handle -ENODEV path individually

Dixit, Ashutosh ashutosh.dixit at intel.com
Tue Dec 14 04:33:56 UTC 2021


On Mon, 13 Dec 2021 10:12:08 -0800, Zbigniew Kempczyński wrote:
>
> As Ashutosh noticed I've handled errors from the kernel too wide
> packing it to same error bag and returning system memory region in this
> case. That's of course is wrong and can lead to return system memory on
> discrete if invalid arguments would be passed to the query.
>
> Return previous behavior of query memory regions handling -ENODEV path
> individually. For this error lets assume we got kernel which doesn't
> support this query yet so returning system memory region is a reasonable
> choice because this region exists for all of i915 gens.

Looks good now so this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>

But could you please point out where the -ENODEV return code is coming
from and which stable kernel. Thanks.


More information about the igt-dev mailing list