[igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Added igt_spin_end for submit_slice subtest

[Chris Wilson]

Quoting Arjun Melkaveri (2021-12-16 08:08:05)
> Due to new ctx implementation , "submit_slice" subtests are waiting for
> long time at I915_GEM_WAIT.
> Adding igt_spin_end resolves this issue.
> 
> Signed-off-by: Arjun Melkaveri <arjun.melkaveri at intel.com>
> Cc: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
> ---
>  tests/i915/gem_exec_schedule.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
> index 68457406..2c72c5e1 100644
> --- a/tests/i915/gem_exec_schedule.c
> +++ b/tests/i915/gem_exec_schedule.c
> @@ -875,6 +875,7 @@ static void submit_slice(int i915, const intel_ctx_cfg_t *cfg,
>                 if (timeline != -1)
>                         close(timeline);
>  
> +               igt_spin_end(spin);

No. This completely breaks the test. The spinner is terminated on the
GPU by cancel_spinner(). That was broken by the conversion.

The timeout is the intentional failure condition for the scheduler being
broken; except in this case the test was broken first.
-Chris