[igt-dev] [PATCH i-g-t] meson: Turn off -Werror

[Chris Wilson]

Quoting Petri Latvala (2021-02-01 08:07:34)
> On Mon, Feb 01, 2021 at 08:01:31AM +0000, Chris Wilson wrote:
> > Quoting Petri Latvala (2021-02-01 06:33:39)
> > > No, we don't want all warnings ever to be errors. While being rid of
> > > compile warnings (especially the more obscure ones from future
> > > compilers) is great, having it on always is not acceptable. It's not
> > > even on "by default", it was non-overrideably set on.
> > > 
> > > Not to mention adding -Werror to compiler flags is the incorrect way
> > > of turning it on. Use the meson command line flag --werror instead on
> > > whatever local checkout or company-internal fork you're using, where
> > > you have control over which compilers are used. Turning it on
> > > unconditionally in an upstream repository for all current and future
> > > compilers is never ok.
> > 
> > Do you have a plan to enable --werror for CI?
> 
> 
> For select distros, possibly.

If you are confident we can enable Werror and keep [more] warnings from
entering, I accept that I acted out of annoyance that we were not doing
a good enough job in keeping the code clean.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris