[igt-dev] [PATCH i-g-t] tests/prime_vgem: Skip userptr test on !llc.

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Mon Feb 1 12:36:54 UTC 2021


It's bad form to change caching on userptr; it's always assumed
to be cached memory. Soon userptr will be fixed to disallow
this, so change this test to continue working when llc is available.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
---
 tests/prime_vgem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
index 07ff69a2455d..1b55b9e6d928 100644
--- a/tests/prime_vgem.c
+++ b/tests/prime_vgem.c
@@ -311,6 +311,7 @@ static void test_userptr(int vgem, int i915)
 	uint32_t *ptr;
 
 	igt_require(has_userptr(i915));
+	igt_require(gem_has_llc(i915));
 
 	scratch.width = 1024;
 	scratch.height = 1024;
@@ -323,7 +324,6 @@ static void test_userptr(int vgem, int i915)
 	*ptr = MI_BATCH_BUFFER_END;
 
 	gem_userptr(i915, ptr, scratch.size, 0, 0, &obj.handle);
-	gem_set_caching(i915, obj.handle, I915_CACHING_NONE); /* for !llc exec */
 
 	gem_execbuf(i915, &execbuf);
 	gem_close(i915, obj.handle);
-- 
2.30.0



More information about the igt-dev mailing list