[igt-dev] [PATCH i-g-t] tests/kms_psr2_sf: Enable selective fetch

[Petri Latvala]

On Thu, Feb 04, 2021 at 05:17:30PM +0200, Souza, Jose wrote:
> On Thu, 2021-02-04 at 17:11 +0200, Petri Latvala wrote:
> > On Thu, Feb 04, 2021 at 06:08:41AM -0800, José Roberto de Souza wrote:
> > > Reload driver enabling PSR2 selective fetch to start to have
> > > some tests coverage of this feature by CI.
> > > 
> > > Cc: Gwan-gyeong Mun <gwan-gyeong.mun at intel.com>
> > > Cc: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya at intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> > > ---
> > >  tests/kms_psr2_sf.c | 14 ++++++++++++++
> > >  1 file changed, 14 insertions(+)
> > > 
> > > diff --git a/tests/kms_psr2_sf.c b/tests/kms_psr2_sf.c
> > > index 296ed8476..751d6ff03 100644
> > > --- a/tests/kms_psr2_sf.c
> > > +++ b/tests/kms_psr2_sf.c
> > > @@ -24,6 +24,7 @@
> > >  
> > > 
> > > 
> > > 
> > >  #include "igt.h"
> > >  #include "igt_sysfs.h"
> > > +#include "igt_kmod.h"
> > >  #include "igt_psr.h"
> > >  #include <errno.h>
> > >  #include <stdbool.h>
> > > @@ -544,6 +545,14 @@ static void cleanup(data_t *data)
> > >  	igt_remove_fb(data->drm_fd, &data->fb_test);
> > >  }
> > >  
> > > 
> > > 
> > > 
> > > +static void reload_driver(bool enable_sel_fetch)
> > > +{
> > > +	const char *params = enable_sel_fetch ? "enable_psr2_sel_fetch=1" : "";
> > > +
> > > +	igt_i915_driver_unload();
> > > +	igt_assert_eq(igt_i915_driver_load(params), 0);
> > > +}
> > 
> > 
> > Does this parameter need to be set at load time or would igt_params_set() suffice?
> 
> At driver load time, otherwise more handling would be needed in kernel and IGT.
> But yeah the kernel parameter right now have the wrong permission, sending a kernel patch fixing it.

We're blacklisting module reloads anyway (see top of
tests/intel-ci/blacklist.txt), and this test will need to be as well
for the same reasons.

What's the test runtime? Are we able to add it to
fast-feedback.testlist until the reload is no longer needed?


-- 
Petri Latvala