[igt-dev] [PATCH i-g-t 2/3] intel_gpu_top: Aggregate clients by PID by default
Chris Wilson
chris at chris-wilson.co.uk
Wed Feb 10 11:03:37 UTC 2021
Quoting Tvrtko Ursulin (2021-02-10 10:55:44)
>
> On 10/02/2021 10:35, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2021-02-10 09:37:55)
> > Ok, that works very well. Hmm. The sort order does seem a little jumpy
> > though. May I suggest ac->id = -c->pid; instead of num;
>
> Done it although I thought 1st pass being sort by pid already, num as id
> would follow a stable order. I guess your point was inversion to
> preserve order when cycling sort modes?
I thought that makes more sense for 'aggregate-by-pid', that it should
either be in ascending/descending pid order for idle.
It just felt very jumpy; it may have been tiny amount of %busy, but I
suspected it may have been slightly unstable sorting with changing
clients.
-Chris
More information about the igt-dev
mailing list