[igt-dev] [i-g-t 1/2] lib/adl_s: Add ADL-S PCIids

[Surendrakumar Upadhyay, TejaskumarX]

> -----Original Message-----
> From: Petri Latvala <petri.latvala at intel.com>
> Sent: 11 February 2021 15:05
> To: Surendrakumar Upadhyay, TejaskumarX
> <tejaskumarx.surendrakumar.upadhyay at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Srivatsa, Anusha
> <anusha.srivatsa at intel.com>; De Marchi, Lucas
> <lucas.demarchi at intel.com>; Pandey, Hariom <hariom.pandey at intel.com>
> Subject: Re: [igt-dev] [i-g-t 1/2] lib/adl_s: Add ADL-S PCIids
> 
> On Thu, Feb 11, 2021 at 02:29:55PM +0530, Tejas Upadhyay wrote:
> > Taken from kernel commit:
> > 0883d63b19bb drm/i915/adl_s: Add ADL-S platform info and PCI ids
> 
> But that's false though. In that commit, DG1 IDS come before ADL-S.
> 
> Not to mention the other missing changes that are done before that commit
> are completely missing from this patch, like the removal of invalid EHL ids
> and sorting of EHL/JSL.
> 
> You're meant to just copy the file as is, not take select parts of it.
> 

I was trying to do it for only ADLS as my patch concerned about that platform. Ok, I will send one patch independent to sync with kernel i915 PCIids first.

Tejas
> --
> Petri Latvala
> 
> 
> >
> > Signed-off-by: Caz Yokoyama <caz.yokoyama at intel.com>
> > Signed-off-by: Tejas Upadhyay
> <tejaskumarx.surendrakumar.upadhyay at intel.com>
> > ---
> >  lib/i915_pciids.h | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> > index 3b5ed1e4..ba87b458 100644
> > --- a/lib/i915_pciids.h
> > +++ b/lib/i915_pciids.h
> > @@ -628,6 +628,17 @@
> >  	INTEL_VGA_DEVICE(0x4C90, info), \
> >  	INTEL_VGA_DEVICE(0x4C9A, info)
> >
> > + /* ADL-S */
> > + #define INTEL_ADLS_IDS(info) \
> > +	INTEL_VGA_DEVICE(0x4680, info), \
> > +	INTEL_VGA_DEVICE(0x4681, info), \
> > +	INTEL_VGA_DEVICE(0x4682, info), \
> > +	INTEL_VGA_DEVICE(0x4683, info), \
> > +	INTEL_VGA_DEVICE(0x4690, info), \
> > +	INTEL_VGA_DEVICE(0x4691, info), \
> > +	INTEL_VGA_DEVICE(0x4692, info), \
> > +	INTEL_VGA_DEVICE(0x4693, info)
> > +
> >  /* DG1 */
> >  #define INTEL_DG1_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x4905, info), \
> > --
> > 2.30.0
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev