[igt-dev] [PATCH i-g-t] i915/gem_pread: Added test description for test case

[Katarzyna Dec]

On Sat, Sep 05, 2020 at 05:02:03PM +0530, apoorva1.singh at intel.com wrote:
> From: Apoorva Singh <apoorva1.singh at intel.com>
> 
> Added test description to all the available subtests.
> 
> Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> Cc: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  tests/i915/gem_pread.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/i915/gem_pread.c b/tests/i915/gem_pread.c
> index 6d12b8e9..19376aac 100644
> --- a/tests/i915/gem_pread.c
> +++ b/tests/i915/gem_pread.c
> @@ -39,6 +39,8 @@
>  #include <sys/time.h>
>  #include "drm.h"
>  
> +IGT_TEST_DESCRIPTION("Basic sanity and perfromance testing of PREAD IOCTL.");
> +
>  #define MiB(x) ((x) * 1024 * 1024)
>  
>  typedef void *(*mmap_fn_t)(int, uint32_t, uint64_t, uint64_t, unsigned int);
> @@ -154,6 +156,7 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
>  		src = malloc(object_size);
>  	}
>  
> +	igt_describe("Test the performance of reading from gem object");
>  	igt_subtest("bench") {
>  		for (count = 1; count <= 1<<17; count <<= 1) {
>  			struct timeval start, end;
> @@ -169,10 +172,14 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
>  		}
>  	}
>  
> +	igt_describe("Verify reading from gem object into address space mapped "
> +	       "(using different mapping methods) to itself works fine");
>  	igt_subtest("self")
>  		pread_self(fd);
>  
>  	for (c = cache; c->level != -1; c++) {
> +		igt_describe_f("Test the performance of reading from gem object with "
> +		       "%s caching mode", c->name);
>  		igt_subtest(c->name) {
>  			gem_set_caching(fd, dst, c->level);
>  
LGTM :)
Reviewed-by: Katarzyna Dec <katarzyna.dec at intel.com>

Kasia :)
> -- 
> 2.28.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev