[igt-dev] [PATCH i-g-t] tests/kms_invalid_dotclock: Skip the test if big joiner is supported

[Nautiyal, Ankit K]

Hi Petri,

Thanks for your comments. Please find my response inline:

On 2/25/2021 2:53 PM, Petri Latvala wrote:
> On Thu, Feb 25, 2021 at 02:39:54PM +0530, Ankit Nautiyal wrote:
>> Currently the test assumes that the modes with clock more than the
>> maximum dot clock will be rejected. This fails in case of
>> platforms that combine multiple pipes and modes higher than the
>> maximum dotclock can still be supported.
>>
>> This patch adds a check to skip the test if big joiner can be
>> supported for a given platform and connector.
>>
>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
>> ---
>>   tests/kms_invalid_dotclock.c | 51 ++++++++++++++++++++++++++++++++++--
>>   1 file changed, 49 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/kms_invalid_dotclock.c b/tests/kms_invalid_dotclock.c
>> index 402629ab..5692736b 100644
>> --- a/tests/kms_invalid_dotclock.c
>> +++ b/tests/kms_invalid_dotclock.c
>> @@ -44,6 +44,44 @@ static bool has_scaling_mode_prop(data_t *data)
>>   				    NULL, NULL, NULL);
>>   }
>>   
>> +static bool
>> +is_dsc_capable(int drm_fd, drmModeConnector *connector)
>> +{
>> +	int debugfs_fd = igt_debugfs_dir(drm_fd);
>> +	char filename[128];
>> +	char buf[512];
>> +	bool dsc = false;
>> +
>> +	sprintf(filename, "%s-%d",
>> +		kmstest_connector_type_str(connector->connector_type),
>> +		connector->connector_type_id);
>> +
>> +	strcat(filename, "/i915_dsc_fec_support");
>> +
>> +	if (igt_debugfs_simple_read(debugfs_fd, filename, buf,
>> +				    sizeof(buf)) > 0)
>> +		dsc = strstr(buf, "DSC_Sink_Support: yes") ? true : false;
>> +
>> +	close(debugfs_fd);
>> +
>> +	return dsc;
>> +}
> Consider moving this to lib/. There's another such function in
> kms_dp_dsc.c already.

Agreed. To be honest this quite "inspired" from the kms_dp_dsc.c :)

In the test kms_dp_dsc, there are other functions as well which read the 
same debugfs entry and parse different cap/support.

The  igt_debugfs_dir is opened once in the beginning of the test and 
read again and again in different functions.

What do you suggest? Should we move only the common function? or move 
other functions as well.

Also, the common function will need to be passed an open debugfs fd.

So the test using will open debugfs, call this common function and close 
the debugfs.

Thanks & Regards,

Ankit


>