[igt-dev] [PATCH i-g-t] tests/i915/perf: drop check on report reason

[Umesh Nerlige Ramappa]

On Wed, Dec 16, 2020 at 10:38:20AM +0200, Lionel Landwerlin wrote:
>Learning the experimental way that ICL can generate 2 back to back
>timer reports with the same timestamp...
>
>Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

Hmm, it's tough to generalize this check then, agree to drop it.

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>

Thanks,
Umesh

>---
> tests/i915/perf.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
>diff --git a/tests/i915/perf.c b/tests/i915/perf.c
>index f09431472..664fd0a94 100644
>--- a/tests/i915/perf.c
>+++ b/tests/i915/perf.c
>@@ -780,7 +780,6 @@ gen8_sanity_check_test_oa_reports(const uint32_t *oa_report0,
> 					format.b_off);
> 	uint32_t *rpt1_b = (uint32_t *)(((uint8_t *)oa_report1) +
> 					format.b_off);
>-	uint32_t report_reason0, report_reason1;
> 	uint32_t b;
> 	uint32_t ref;
>
>@@ -791,14 +790,6 @@ gen8_sanity_check_test_oa_reports(const uint32_t *oa_report0,
> 	freq = time_delta ? ((uint64_t)clock_delta * 1000) / time_delta : 0;
> 	igt_debug("freq = %"PRIu64"\n", freq);
>
>-	/* Either we have 2 reports back to back with the same
>-	 * timestamp and those should have different reason, or we
>-	 * were able to compute a frequency because the timestamps are
>-	 * different.
>-	 */
>-	igt_assert(freq || (gen8_report_reason(oa_report0) !=
>-			    gen8_report_reason(oa_report1)));
>-
> 	igt_debug("clock delta = %"PRIu32"\n", clock_delta);
>
> 	max_delta = clock_delta * intel_perf->devinfo.n_eus;
>-- 
>2.29.2
>