[igt-dev] [PATCH i-g-t v4] tests/kms_plane: Added test description

[Karthik B S]

On 1/7/2021 3:41 AM, Arundhati Hagaragi wrote:
> Added test description for test case
>
> Cc: Gupta, Nidhi1 <nidhi1.gupta at intel.com>
> Cc: B S, Karthik <Karthik.B.S at intel.com>
> Signed-off-by: Arundhati Hagaragi <arundhati.hagaragi at intel.com>
>
> v2: modified subtests description to be more specific. (Karthik)
> v3: added and modified description for subtests to be more specific. (Karthik)
> v4: modified description for subtests
> ---
>   tests/kms_plane.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 2f0c9d9d..8bd4bdb6 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -1034,10 +1034,12 @@ run_tests_for_pipe_plane(data_t *data, enum pipe pipe)
>   		igt_require(data->display.pipes[pipe].n_planes > 0);
>   	}
>   
> +	igt_describe("verify the pixel formats for given plane and pipe");
>   	igt_subtest_f("pixel-format-pipe-%s-planes",
>   		      kmstest_pipe_name(pipe))
>   		test_pixel_formats(data, pipe);
>   
> +	igt_describe("verify the pixel formats for given plane and pipe with clamping test");
s/clamping test/source clamping
>   	igt_subtest_f("pixel-format-pipe-%s-planes-source-clamping",
>   		      kmstest_pipe_name(pipe)) {
>   		data->crop = 4;
> @@ -1045,29 +1047,35 @@ run_tests_for_pipe_plane(data_t *data, enum pipe pipe)
>   	}
>   
>   	data->crop = 0;
> +	igt_describe("verify plane position using two planes to create a fully covered screen");
>   	igt_subtest_f("plane-position-covered-pipe-%s-planes",
>   		      kmstest_pipe_name(pipe))
>   		test_plane_position(data, pipe, 0);
>   
> +	igt_describe("verify plane position using two planes to create a partially covered screen");
>   	igt_subtest_f("plane-position-hole-pipe-%s-planes",
>   		      kmstest_pipe_name(pipe))
>   		test_plane_position(data, pipe,
>   				    TEST_POSITION_PARTIALLY_COVERED);
>   
> +	igt_describe("verify plane position using two planes to create a partially covered screen and check for DPMS");
>   	igt_subtest_f("plane-position-hole-dpms-pipe-%s-planes",
>   		      kmstest_pipe_name(pipe))
>   		test_plane_position(data, pipe,
>   				    TEST_POSITION_PARTIALLY_COVERED |
>   				    TEST_DPMS);
>   
> +	igt_describe("verify the panning at top-left position using a plane");

s/the panning/plane panning

s/a plane/primary plane

Same as above for all panning subtests.

With these minor changes, the patch LGTM.

Reviewed-by: Karthik B S <karthik.b.s at intel.com>

>   	igt_subtest_f("plane-panning-top-left-pipe-%s-planes",
>   		      kmstest_pipe_name(pipe))
>   		test_plane_panning(data, pipe, TEST_PANNING_TOP_LEFT);
>   
> +	igt_describe("verify the panning at bottom-right position using a plane");
>   	igt_subtest_f("plane-panning-bottom-right-pipe-%s-planes",
>   		      kmstest_pipe_name(pipe))
>   		test_plane_panning(data, pipe, TEST_PANNING_BOTTOM_RIGHT);
>   
> +	igt_describe("verify panning at bottom-right position using a plane and executes system suspend cycles");
>   	igt_subtest_f("plane-panning-bottom-right-suspend-pipe-%s-planes",
>   		      kmstest_pipe_name(pipe))
>   		test_plane_panning(data, pipe, TEST_PANNING_BOTTOM_RIGHT |