[igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time

Petri Latvala petri.latvala at intel.com
Thu Jan 21 10:04:20 UTC 2021


On Thu, Jan 21, 2021 at 11:59:48AM +0200, B, Jeevan wrote:
> >-----Original Message-----
> >From: Petri Latvala <petri.latvala at intel.com>
> >Sent: Wednesday, January 20, 2021 5:51 PM
> >To: B, Jeevan <jeevan.b at intel.com>
> >Cc: igt-dev at lists.freedesktop.org
> >Subject: Re: [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce
> >execution time
> >
> >On Wed, Jan 20, 2021 at 05:11:43PM +0530, Jeevan B wrote:
> >> Restricting the execution to 2 pipes
> >> with this change we see 50% improvement in time efficiency.
> >>
> >> v2: Updated commit message.
> >>
> >> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> >> Reviewed-by: Uma Shankar <uma.shankar at intel.com>
> >> ---
> >>  tests/kms_rotation_crc.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index
> >> 33a97cca..cc404a61 100644
> >> --- a/tests/kms_rotation_crc.c
> >> +++ b/tests/kms_rotation_crc.c
> >> @@ -421,6 +421,10 @@ static void test_plane_rotation(data_t *data, int
> >plane_type, bool test_bad_form
> >>  		if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
> >>  			continue;
> >>
> >> +		/* restricting the execution to 2 pipes to reduce execution
> >time*/
> >> +		if (pipe > PIPE_B && !data->extended)
> >> +			break;
> >> +
> >
> >What's the plan for platforms that might have two pipes as A+C?
> Hmm, Can we add a flag check here ?? 
> So that I can exit when tests gets executed on 2 pipes. 

Yeah a separate counter is what you need to do here.


-- 
Petri Latvala


More information about the igt-dev mailing list