[igt-dev] [PATCH i-g-t 1/2] tests/kms_rotation_crc: reduce execution time

[Juha-Pekka Heikkila]

On 27.1.2021 13.41, Petri Latvala wrote:
> On Fri, Jan 22, 2021 at 12:05:21AM +0530, Jeevan B wrote:
>> Restricting the execution to 2 pipes
>> with this change we see 50% improvement in time efficiency.
>>
>> v2: Updated commit message
>> v3: Updated check condition
>>
>> Signed-off-by: Jeevan B<jeevan.b at intel.com>
> No objections from me but I'd like someone more knowledgeable with the
> display code than myself to assess whether limiting this to the first
> two pipes doesn't leave a glaring coverage gap. J-P maybe?
> 

I'm ok with this change. Other pipes are tested by other kms tests which 
are not as slow.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

>> ---
>>   tests/kms_rotation_crc.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
>> index 33a97cca..e7072e20 100644
>> --- a/tests/kms_rotation_crc.c
>> +++ b/tests/kms_rotation_crc.c
>> @@ -405,6 +405,7 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
>>   	igt_display_t *display = &data->display;
>>   	igt_output_t *output;
>>   	enum pipe pipe;
>> +	int pipe_count = 0;
>>   
>>   	if (plane_type == DRM_PLANE_TYPE_CURSOR)
>>   		igt_require(display->has_cursor_plane);
>> @@ -421,6 +422,11 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
>>   		if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
>>   			continue;
>>   
>> +		/* restricting the execution to 2 pipes to reduce execution time*/
>> +		if (pipe_count == 2 && !data->extended)
>> +			break;
>> +		pipe_count++;
>> +
>>   		igt_output_set_pipe(output, pipe);
>>   
>>   		plane = igt_output_get_plane_type(output, plane_type);
>> -- 
>> 2.19.1
>>