[igt-dev] [PATCH 2/2] kms_addfb_basic: Check for AMDGPU and MSM bad pitch.

Mark Yacoub markyacoub at chromium.org
Thu Jul 1 17:44:24 UTC 2021


From: Mark Yacoub <markyacoub at google.com>

[Why]
AMDGPU and MSM devices have a known errno when it fails coorectly for
bad pitches.

[How]
Assert `errno` to `EINVAL` for both AMDGPU and MSM as well.

Signed-off-by: Mark Yacoub <markyacoub at chromium.org>
---
 tests/kms_addfb_basic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 85c14be5..91fb6ac9 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -310,7 +310,7 @@ static void pitch_tests(int fd)
 			f.pitches[0] = bad_pitches[i];
 			igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
 			igt_assert(errno != 0);
-			if (is_i915_device(fd)) {
+			if (is_i915_device(fd) || is_amdgpu_device(fd) || is_msm_device(fd)) {
 				igt_assert_eq(errno, EINVAL);
 			} else if (is_nouveau_device(fd)) {
 				if (bad_pitches[i] > 4 * 1024)
-- 
2.32.0.93.g670b81a890-goog



More information about the igt-dev mailing list