[igt-dev] [PATCH 1/2] drmtest: Add is_msm_device check
Rodrigo Siqueira
Rodrigo.Siqueira at amd.com
Tue Jul 6 13:37:08 UTC 2021
On 07/01, Mark Yacoub wrote:
> From: Mark Yacoub <markyacoub at google.com>
>
> Add support for MSM drivers.
I think you're not adding "support for MSM", it looks like you're adding
helpers to check msm driver. Anyway, this patch lgtm.
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Signed-off-by: Mark Yacoub <markyacoub at chromium.org>
> ---
> lib/drmtest.c | 5 +++++
> lib/drmtest.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index a8ba6e11..e1f9b115 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -114,6 +114,11 @@ bool is_i915_device(int fd)
> return __is_device(fd, "i915");
> }
>
> +bool is_msm_device(int fd)
> +{
> + return __is_device(fd, "msm");
> +}
> +
> bool is_nouveau_device(int fd)
> {
> /* Currently all nouveau-specific codepaths require libdrm */
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index d393dbf1..7d17a0f9 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -102,6 +102,7 @@ void igt_require_vc4(int fd);
>
> bool is_amdgpu_device(int fd);
> bool is_i915_device(int fd);
> +bool is_msm_device(int fd);
> bool is_nouveau_device(int fd);
> bool is_vc4_device(int fd);
>
> --
> 2.32.0.93.g670b81a890-goog
>
--
Rodrigo Siqueira
https://siqueira.tech
More information about the igt-dev
mailing list