[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Vidya Srinivas vidya.srinivas at intel.com
Wed Jul 14 08:00:02 UTC 2021


Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI.
The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI
By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI
was being used.

Credits-to: Ashutosh Dixit <ashutosh.dixit at intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a3529dc2190f..8020216c1594 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
-- 
2.32.0



More information about the igt-dev mailing list