[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

[Srinivas, Vidya]

Thank you so much Ram. Kunal, kindly help merge this. Sorry for the trouble.

Regards
Vidya

-----Original Message-----
From: C, Ramalingam <ramalingam.c at intel.com> 
Sent: Wednesday, July 14, 2021 3:34 PM
To: Srinivas, Vidya <vidya.srinivas at intel.com>
Cc: igt-dev at lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

On 2021-07-14 at 13:30:02 +0530, Vidya Srinivas wrote:
> Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.
> 
> is_6bpc is supposed to return false if connector is not eDP or DSI.
> The right check will be DRM_MODE_CONNECTOR_eDP && 
> DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || 
> DRM_MODE_CONNECTOR_DSI was being used.
> 
> Credits-to: Ashutosh Dixit <ashutosh.dixit at intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
LGTM.

Reviewed-by: Ramalingam C <ramalingam.c at intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a3529dc2190f..8020216c1594 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
>  		return false;
>  
>  	c = output->config.connector;
> -	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
>  		c->connector_type != DRM_MODE_CONNECTOR_DSI)
>  		return false;
>  
> --
> 2.32.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev