[igt-dev] [PATCH i-g-t 9/9] tests/i915/gen9_exec_parse: Expect sync_fence_status to succeed

Jason Ekstrand jason at jlekstrand.net
Wed Jul 14 19:33:38 UTC 2021


On Wed, Jul 14, 2021 at 12:39 PM Vudum, Lakshminarayana
<lakshminarayana.vudum at intel.com> wrote:
>
> What is expected from myside? Should these email's I received go to a different person?

The're going to make a few small IGT CI changes.  Daniel thought you'd
want to be in the loop.

--Jason

> Lakshmi.
> -----Original Message-----
> From: Jason Ekstrand <jason at jlekstrand.net>
> Sent: Wednesday, July 14, 2021 10:32 AM
> To: igt-dev at lists.freedesktop.org
> Cc: Jason Ekstrand <jason at jlekstrand.net>; Vudum, Lakshminarayana <lakshminarayana.vudum at intel.com>
> Subject: [PATCH i-g-t 9/9] tests/i915/gen9_exec_parse: Expect sync_fence_status to succeed
>
> i915 is switching to synchronously parse command buffers and deliver the error immediately instead of trying to propagate it to the fence.  We can assume that, if there is an error, it's returned from execbuf.
>
> Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
> Cc: Lakshminarayana Vudum <lakshminarayana.vudum at intel.com>
> ---
>  tests/i915/gen9_exec_parse.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/i915/gen9_exec_parse.c b/tests/i915/gen9_exec_parse.c index b35f2cb43..512891873 100644
> --- a/tests/i915/gen9_exec_parse.c
> +++ b/tests/i915/gen9_exec_parse.c
> @@ -72,10 +72,8 @@ __checked_execbuf(int i915, struct drm_i915_gem_execbuffer2 *eb)
>         fence = eb->rsvd2 >> 32;
>
>         sync_fence_wait(fence, -1);
> -       err = sync_fence_status(fence);
> +       igt_assert(sync_fence_status(fence) >= 0);
>         close(fence);
> -       if (err < 0)
> -               return err;
>
>         return 0;
>  }
> --
> 2.31.1
>


More information about the igt-dev mailing list