[igt-dev] [PATCH i-g-t] tests/kms_dither: Make dither tests generic

[Mark Yacoub]

On Thu, Jul 15, 2021 at 11:16 PM Bhanuprakash Modem
<bhanuprakash.modem at intel.com> wrote:
>
> As dithering is not Intel specific, it would be good to make
> these tests generic, so that it can be easy to extend/re-use
> for other platforms.
>
> Cc: Uma Shankar <uma.shankar at intel.com>
> Cc: Mark Yacoub <markyacoub at chromium.org>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>  tests/kms_dither.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_dither.c b/tests/kms_dither.c
> index 49f7935268..65ca169ac2 100644
> --- a/tests/kms_dither.c
> +++ b/tests/kms_dither.c
> @@ -90,6 +90,8 @@ static dither_status_t get_dither_state(data_t *data)
>         int dir, res;
>         dither_status_t status;
>
> +       igt_require(is_i915_device(data->drm_fd));
you can use `igt_require_intel(int fd)` for brevity.
> +
I'd suggest to move this right above `igt_debugfs_simple_read(dir,
"i915_display_info")` instead of igt_debugfs_dir(data->drm_fd) cause
this requirement is strictly for opening i915_display_info, making it
easier in the future to extend to other platforms by converting
igt_require_intel to `if (is_i915_device) do_intel_logic; else if
(is_other_platform) do_other_logic;`
>         dir = igt_debugfs_dir(data->drm_fd);
>         igt_assert(dir >= 0);
>
> @@ -230,7 +232,7 @@ igt_main
>         data_t data = { 0 };
>
>         igt_fixture {
> -               data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> +               data.drm_fd = drm_open_driver_master(DRIVER_ANY);
Thanks!
>                 kmstest_set_vt_graphics_mode();
>
>                 igt_display_require(&data.display, data.drm_fd);
> --
> 2.20.1
>