[igt-dev] [PATCH i-g-t v6 05/16] Add PXP attribute support in batchbuffer and buffer_ops libs

[Dixit, Ashutosh]

On Fri, 16 Jul 2021 02:23:23 -0700, Alan Previn wrote:
>
> Eventually when we get to testing PXP rendering capability,
> we shall reuse lib's rendercopy feature. Rendercopy libraries
> shall retrieve information about PXP-session-enablement and
> which buffers are protected from these new flags.

A couple of nits below otherwise this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>

> diff --git a/lib/intel_batchbuffer.h b/lib/intel_batchbuffer.h
> index bd417e99..1c5ce3fa 100644
> --- a/lib/intel_batchbuffer.h
> +++ b/lib/intel_batchbuffer.h
>
> +static inline uint32_t intel_bb_pxp_appid(struct intel_bb *ibb)
> +{
> +	igt_assert(ibb);

Not sure if we need these asserts in all these functions. Most similar
functions don't seem to have these but some do too so maybe ok.

> +	return ibb->pxp.appid;
> +}
> +
>  struct drm_i915_gem_exec_object2 *
>  intel_bb_add_object(struct intel_bb *ibb, uint32_t handle, uint64_t size,
>		    uint64_t offset, uint64_t alignment, bool write);
> @@ -687,3 +714,4 @@ typedef void (*igt_huc_copyfunc_t)(int fd,
>
>  igt_huc_copyfunc_t	igt_get_huc_copyfunc(int devid);
>  #endif
> +

Delete this empty line at the bottom.