[igt-dev] [PATCH] tests/kms_atomic: igt_require_pipe_crc for plane_immutable_zpos

Rodrigo Siqueira Rodrigo.Siqueira at amd.com
Fri Jul 23 14:37:28 UTC 2021


On 07/09, Mark Yacoub wrote:
> From: Mark Yacoub <markyacoub at google.com>
> 
> [Why]
> kms_atomic:plane_immutable_zpos subtest uses CRC in debugfs which is
> not supported by some drivers.
> 
> [How]
> igt_require_pipe_crc before the test begins.
> 
> Test: kms_atomic:plane-immutable-zpos on ChromeOS Trogdor(msm)
> Signed-off-by: Mark Yacoub <markyacoub at chromium.org>
> ---
>  tests/kms_atomic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> index df9c9df7..4b262257 100644
> --- a/tests/kms_atomic.c
> +++ b/tests/kms_atomic.c
> @@ -375,6 +375,7 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
>  	uint32_t w_lower, h_lower, w_upper, h_upper;
>  
>  	igt_require(n_planes >= 2);
> +	igt_require_pipe_crc(display->drm_fd);

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>

Just for curiosity, what is the result for this test in your Zork
system?

Thanks
  
>  	mode = igt_output_get_mode(output);
>  	primary = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> -- 
> 2.32.0.93.g670b81a890-goog
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Figt-dev&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C96d85f55a3064d29832c08d942ee2170%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637614413326773397%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=SKj30lk%2BZtlcT9iiROaeRlOnnh7psSUFzSbfi2w7JF0%3D&reserved=0

-- 
Rodrigo Siqueira
https://siqueira.tech


More information about the igt-dev mailing list