[igt-dev] [PATCH i-g-t] tests/kms: Return false in gem_has_lmem for kernels not having DRM_I915_QUERY_MEMORY_REGIONS support

[Srinivas, Vidya]

> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit at intel.com>
> Sent: Sunday, July 25, 2021 2:50 AM
> To: Srinivas, Vidya <vidya.srinivas at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Modem, Bhanuprakash
> <bhanuprakash.modem at intel.com>; Shankar, Uma
> <uma.shankar at intel.com>; Almahallawy, Khaled
> <khaled.almahallawy at intel.com>; Joshi, Kunal1 <kunal1.joshi at intel.com>;
> Heikkila, Juha-pekka <juha-pekka.heikkila at intel.com>; Lin, Charlton
> <charlton.lin at intel.com>; Latvala, Petri <petri.latvala at intel.com>; Lin,
> Charlton <charlton.lin at intel.com>
> Subject: Re: [PATCH i-g-t] tests/kms: Return false in gem_has_lmem for
> kernels not having DRM_I915_QUERY_MEMORY_REGIONS support
> 
> On Sat, 24 Jul 2021 09:53:17 -0700, Vidya Srinivas wrote:
> >
> > @@ -164,6 +175,9 @@ uint8_t gem_get_lmem_region_count(int fd)
> >   */
> >  bool gem_has_lmem(int fd)
> >  {
> > +	int ret = gem_has_memregion_query_support(fd);
> > +	if (ret == ENOSYS || ret == ENOTSUP)
> > +		return false;
> >	return gem_get_lmem_region_count(fd) > 0;
> 
> gem_get_query_memory_regions is still broken. So we should use
> __i915_query_items there.
> 
> The patch title also should not say tests/kms.

Thank you so much Ashutosh. Kindly have a check of the patch updated with your review comments addressed.
https://patchwork.freedesktop.org/patch/446489/?series=92935&rev=4

Regards
Vidya