[igt-dev] [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests

[Srinivas, Vidya]

> -----Original Message-----
> From: Shankar, Uma <uma.shankar at intel.com>
> Sent: Tuesday, July 27, 2021 1:27 AM
> To: Srinivas, Vidya <vidya.srinivas at intel.com>; igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>;
> Almahallawy, Khaled <khaled.almahallawy at intel.com>; Joshi, Kunal1
> <kunal1.joshi at intel.com>; Heikkila, Juha-pekka <juha-
> pekka.heikkila at intel.com>; Lin, Charlton <charlton.lin at intel.com>; Latvala,
> Petri <petri.latvala at intel.com>; Lin, Charlton <charlton.lin at intel.com>
> Subject: RE: [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests
> 
> >
> > > -----Original Message-----
> > > From: Srinivas, Vidya <vidya.srinivas at intel.com>
> > > Sent: Friday, July 23, 2021 3:09 PM
> > > To: igt-dev at lists.freedesktop.org
> > > Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>;
> Shankar, Uma
> > > <uma.shankar at intel.com>; Almahallawy, Khaled
> > > <khaled.almahallawy at intel.com>; Joshi, Kunal1
> > > <kunal1.joshi at intel.com>; Heikkila, Juha-pekka <juha-
> > > pekka.heikkila at intel.com>; Lin, Charlton <charlton.lin at intel.com>;
> > > Latvala, Petri <petri.latvala at intel.com>; Srinivas, Vidya
> > > <vidya.srinivas at intel.com>; Lin, Charlton <charlton.lin at intel.com>
> > > Subject: [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests
> > >
> > > We see the HW stride length tests are crashing when run in sequence.
> > > Individually, they PASS.
> > > This is happening due to missing data.ibb creation before the
> > > test_scanout. Patch fixes the same.
> >
> > Looks Good to me.
> > Reviewed-by: Uma Shankar <uma.shankar at intel.com>
> 
> Meanwhile while we are at it, I feel the intel_bb_create at fixture can be
> dropped as well. Currently its created but not getting destroyed in cleanup.
> Please check and update your patch fixing that as well.
>

Thank you Uma. This patch was removing the crash. But with this too, we see failures in CRC.
I have updated the patch. Even with this updated patch, we are seeing one random CRC failure when
run in sequence mostly either in x-tiled-max-hw-stride-32bpp-rotate-0-async-flip 
or y-tiled-max-hw-stride-32bpp-rotate-180-async-flip (CRC failure with async flip, crc shouldn't match for checked round).
However, if we run the test individually, it PASSES. Something more might be missing. For now, is it good to merge this
patch? https://patchwork.freedesktop.org/patch/447014/?series=92936&rev=2

Regards
Vidya


 
> Thanks & Regards,
> Uma Shankar
> 
> > > Signed-off-by: Lin Charlton <charlton.lin at intel.com>
> > > Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
> > > ---
> > >  tests/kms_big_fb.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index
> > > c6f374bdd073..91439ceb34b6 100644
> > > --- a/tests/kms_big_fb.c
> > > +++ b/tests/kms_big_fb.c
> > > @@ -978,7 +978,9 @@ igt_main
> > >  igt_require(data.format ==
> > > DRM_FORMAT_C8 ||
> > >
> > > igt_fb_supported_format(data.format));
> > >
> > > igt_require(igt_display_has_format_mod(&data.display, data.format,
> > > data.modifier));
> > > +data.ibb =
> > > intel_bb_create(data.drm_fd, 4096);
> > >  test_scanout(&data);
> > > +intel_bb_destroy(data.ibb);
> > >  }
> > >
> > >  // async flip doesn't support linear fbs.
> > > @@ -994,7 +996,9 @@ igt_main
> > >
> > > igt_require(igt_display_has_format_mod(&data.display, data.format,
> > > data.modifier));
> > >
> > > igt_require_f(data.async_flip_support, "Async Flip is not
> > > supported\n");  data.max_hw_fb_width = min(data.hw_stride /
> > > (formats[j].bpp >> 3), data.max_fb_width);
> > > +data.ibb =
> > > intel_bb_create(data.drm_fd, 4096);
> > >  test_scanout(&data);
> > > +intel_bb_destroy(data.ibb);
> > >  }
> > >  data.async_flip_test = false;
> > >  }
> > > --
> > > 2.32.0
>