[igt-dev] [PATCH i-g-t v2 02/11] lib/i915/gem_mman: add fixed mode to mmap__device_coherent

Dixit, Ashutosh ashutosh.dixit at intel.com
Wed Jul 28 22:23:42 UTC 2021


On Wed, 28 Jul 2021 03:30:32 -0700, Matthew Auld wrote:
>
> diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> index e2514f0c..222e8896 100644
> --- a/lib/i915/gem_mman.c
> +++ b/lib/i915/gem_mman.c
> @@ -383,9 +383,10 @@ void *__gem_mmap__device_coherent(int fd, uint32_t handle, uint64_t offset,
>				      I915_MMAP_OFFSET_WC);
>	if (!ptr)
>		ptr = __gem_mmap__wc(fd, handle, offset, size, prot);
> -
>	if (!ptr)
>		ptr = __gem_mmap__gtt(fd, handle, size, prot);
> +	if (!ptr)
> +		ptr = __gem_mmap_offset__fixed(fd, handle, offset, size, prot);

Wondering if we really want 4 system calls for discrete. Maybe we can move
this up to 2nd place right after __gem_mmap_offset?


More information about the igt-dev mailing list