[igt-dev] [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests

[Srinivas, Vidya]

Thank you very much Lakshmi.

Regards
Vidya

> -----Original Message-----
> From: Vudum, Lakshminarayana <lakshminarayana.vudum at intel.com>
> Sent: Thursday, July 29, 2021 9:55 PM
> To: Srinivas, Vidya <vidya.srinivas at intel.com>; igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>; Shankar,
> Uma <uma.shankar at intel.com>; Almahallawy, Khaled
> <khaled.almahallawy at intel.com>; Lin, Charlton <charlton.lin at intel.com>;
> Lin, Charlton <charlton.lin at intel.com>
> Subject: RE: [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests
> 
> Re-reported.
> 
> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas at intel.com>
> Sent: Thursday, July 29, 2021 12:39 AM
> To: igt-dev at lists.freedesktop.org; Vudum, Lakshminarayana
> <lakshminarayana.vudum at intel.com>
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>; Shankar,
> Uma <uma.shankar at intel.com>; Almahallawy, Khaled
> <khaled.almahallawy at intel.com>; Lin, Charlton <charlton.lin at intel.com>;
> Lin, Charlton <charlton.lin at intel.com>
> Subject: RE: [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests
> 
> Hello Lakshmi,
> 
> Could you kindly help re-run
> https://patchwork.freedesktop.org/series/92936/ Rev 3?
> Thank you so much.
> 
> Regards
> Vidya
> 
> > -----Original Message-----
> > From: Srinivas, Vidya <vidya.srinivas at intel.com>
> > Sent: Wednesday, July 28, 2021 12:25 AM
> > To: igt-dev at lists.freedesktop.org
> > Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>; Shankar,
> Uma
> > <uma.shankar at intel.com>; Almahallawy, Khaled
> > <khaled.almahallawy at intel.com>; Lin, Charlton
> > <charlton.lin at intel.com>; Srinivas, Vidya <vidya.srinivas at intel.com>;
> > Lin, Charlton <charlton.lin at intel.com>
> > Subject: [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests
> >
> > We see the HW stride length tests are crashing when run in sequence.
> > Individually, they PASS.
> > This is happening due to missing data.ibb creation before the test_scanout.
> > Patch fixes the same.
> >
> > Signed-off-by: Charlton Lin <charlton.lin at intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
> > Change-Id: I8a9ec8dd00ff249ef2ef72e0c2da28467e65563c
> > ---
> >  tests/kms_big_fb.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index
> > c6f374bdd073..26c7b8b200eb 100644
> > --- a/tests/kms_big_fb.c
> > +++ b/tests/kms_big_fb.c
> > @@ -852,7 +852,6 @@ igt_main
> >  data.render_copy =
> > igt_get_render_copyfunc(data.devid);
> >
> >  data.bops = buf_ops_create(data.drm_fd); -data.ibb =
> > intel_bb_create(data.drm_fd, 4096);
> >
> >  data.planeclearrgb[0] = 0.0;
> >  data.planeclearrgb[1] = 0.0;
> > @@ -978,7 +977,9 @@ igt_main
> >  igt_require(data.format ==
> > DRM_FORMAT_C8 ||
> >
> > igt_fb_supported_format(data.format));
> >
> > igt_require(igt_display_has_format_mod(&data.display,
> > data.format, data.modifier));
> > +data.ibb =
> > intel_bb_create(data.drm_fd, 4096);
> >  test_scanout(&data);
> > +intel_bb_destroy(data.ibb);
> >  }
> >
> >  // async flip doesn't support linear fbs.
> > @@ -994,7 +995,9 @@ igt_main
> >
> > igt_require(igt_display_has_format_mod(&data.display,
> > data.format, data.modifier));
> >
> > igt_require_f(data.async_flip_support, "Async Flip is not
> > supported\n");
> >
> > data.max_hw_fb_width = min(data.hw_stride / (formats[j].bpp >> 3),
> > data.max_fb_width);
> > +data.ibb =
> > intel_bb_create(data.drm_fd, 4096);
> >  test_scanout(&data);
> > +
> > intel_bb_destroy(data.ibb);
> >  }
> >  data.async_flip_test = false;
> >  }
> > --
> > 2.32.0
> 
>