[igt-dev] [PATCH i-g-t] [RFC] tests/kms_big_fb: Use max stride 128K generic in set_max_hw_stride
Vidya Srinivas
vidya.srinivas at intel.com
Fri Jul 30 09:59:04 UTC 2021
As per kernel i9xx_plane_max_stride, if I915_FORMAT_MOD_X_TILED
stride should be 16*1024 and for other modifiers 32*1024.
However, we see random CRC failures on kernel 5.4
With 64K or 128K, tests PASS. We are keeping 128K for now
to avoid failures on 5.4 kernel.
Signed-off-by: Charlton Lin <charlton.Lin at intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
---
tests/kms_big_fb.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index c6f374bdd073..8f262af0d047 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -754,16 +754,7 @@ test_addfb(data_t *data)
static void
set_max_hw_stride(data_t *data)
{
- if (intel_display_ver(data->devid) >= 13) {
- /*
- * The stride in bytes must not exceed of the size
- * of 128K bytes. For pixel formats of 64bpp will allow
- * for a 16K pixel surface.
- */
- data->hw_stride = 131072;
- } else {
- data->hw_stride = 32768;
- }
+ data->hw_stride = 131072;
}
static data_t data = {};
@@ -941,11 +932,11 @@ igt_main
for (int j = 0; j < ARRAY_SIZE(formats); j++) {
/*
* try only those formats which can show full length.
- * Here 32K is used to have CI test results consistent
- * for all platforms, 32K is smallest number possbily
+ * Here 128K is used to have CI test results consistent
+ * for all platforms, 128K is smallest number possbily
* coming to data.hw_stride from above set_max_hw_stride()
*/
- if (32768 / (formats[j].bpp >> 3) > 8192)
+ if (131072 / (formats[j].bpp >> 3) > 8192)
continue;
data.format = formats[j].format;
--
2.32.0
More information about the igt-dev
mailing list