[igt-dev] [PATCH i-g-t 82/89] lib/igt_dummyload: Stop supporting ALL_ENGINES without an intel_ctx_t

[Zbigniew Kempczyński]

On Fri, Apr 23, 2021 at 04:52:45PM -0500, Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
> ---
>  lib/igt_dummyload.c | 21 ++++++---------------
>  1 file changed, 6 insertions(+), 15 deletions(-)
> 
> diff --git a/lib/igt_dummyload.c b/lib/igt_dummyload.c
> index ac83b331..ae6c9542 100644
> --- a/lib/igt_dummyload.c
> +++ b/lib/igt_dummyload.c
> @@ -129,22 +129,13 @@ emit_recursive_batch(igt_spin_t *spin,
>  	if (opts->engine == ALL_ENGINES) {
>  		struct intel_execution_engine2 *engine;
>  
> -		if (opts->ctx) {
> -			for_each_ctx_engine(fd, opts->ctx, engine) {
> -				if (opts->flags & IGT_SPIN_POLL_RUN &&
> -				    !gem_class_can_store_dword(fd, engine->class))
> -					continue;
> +		igt_assert(opts->ctx);
> +		for_each_ctx_engine(fd, opts->ctx, engine) {
> +			if (opts->flags & IGT_SPIN_POLL_RUN &&
> +			    !gem_class_can_store_dword(fd, engine->class))
> +				continue;
>  
> -				flags[nengine++] = engine->flags;
> -			}
> -		} else {
> -			for_each_context_engine(fd, opts->ctx_id, engine) {
> -				if (opts->flags & IGT_SPIN_POLL_RUN &&
> -				    !gem_class_can_store_dword(fd, engine->class))
> -					continue;
> -
> -				flags[nengine++] = engine->flags;
> -			}
> +			flags[nengine++] = engine->flags;
>  		}
>  	} else {
>  		flags[nengine++] = opts->engine;
> -- 
> 2.31.1
> 

I got no objections.

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew


> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev