[igt-dev] [PATCH i-g-t] tests/kms_big_fb: Use igt_pipe_crc_get_current instead of igt_pipe_crc_collect_crc

Vidya Srinivas vidya.srinivas at intel.com
Tue Jun 8 09:05:06 UTC 2021


CRC mismatch is seen between big and small CRC on
Gen11 systems for subtest y-tiled-32bpp-rotate-0.
Patch changes igt_pipe_crc_collect_crc to igt_pipe_crc_get_current
for collecting CRC for big and small fb to compare.

Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
Change-Id: Ie913127f149f577ab0a034dcbbd4314af17cad52
---
 tests/kms_big_fb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b35727a09bd0..ea12a34157f2 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -331,14 +331,13 @@ static bool test_plane(data_t *data)
 		 * rendering pipeline introduces slight differences into
 		 * the result if we try that, and so the crc will not match.
 		 */
+		igt_pipe_crc_start(data->pipe_crc);
 		copy_pattern(data, small_fb, 0, 0, big_fb, x, y,
 			     small_fb->width, small_fb->height);
 
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
-
-		igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
+		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &small_crc);
 
 		igt_plane_set_fb(plane, big_fb);
 		igt_fb_set_position(big_fb, plane, x, y);
@@ -347,11 +346,12 @@ static bool test_plane(data_t *data)
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
 
-		igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
+		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &big_crc);
 
 		igt_plane_set_fb(plane, NULL);
 
 		igt_assert_crc_equal(&big_crc, &small_crc);
+		igt_pipe_crc_stop(data->pipe_crc);
 	}
 
 	return true;
-- 
2.7.4



More information about the igt-dev mailing list