[igt-dev] [PATCH i-g-t 09/11] tests/kms_dp_dsc: Read the debugfs only once

[Karthik B S]

On 6/9/2021 5:47 PM, venkata.sai.patnana at intel.com wrote:
> From: Patnana Venkata Sai <venkata.sai.patnana at intel.com>
>
> Instead of doing a debugfs_simple_read and then
> a debugfs_read(), lets read the debugfs node just once.
> We anyway get the suitable return from the following
> strstr operation
>
> Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana at intel.com>

LGTM.

Reviewed-by: Karthik B S <karthik.b.s at intel.com>

> Cc: Karthik B S <karthik.b.s at intel.com>
> Cc: Vandita Kulkarni <vandita.kulkarni at intel.com>
> Cc: Navare Manasi D <manasi.d.navare at intel.com>
> ---
>   tests/kms_dp_dsc.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c
> index 2446fd82bb..8bd2102447 100644
> --- a/tests/kms_dp_dsc.c
> +++ b/tests/kms_dp_dsc.c
> @@ -80,8 +80,6 @@ static bool is_dp_dsc_supported(data_t *data)
>   
>   	strcpy(file_name, data->conn_name);
>   	strcat(file_name, "/i915_dsc_fec_support");
> -	igt_require(igt_debugfs_simple_read(data->debugfs_fd, file_name, buf,
> -					    sizeof(buf)) > 0);
>   	igt_debugfs_read(data->drm_fd, file_name, buf);
>   
>   	return strstr(buf, "DSC_Sink_Support: yes");