[igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output

Karthik B S karthik.b.s at intel.com
Mon Jun 14 10:04:31 UTC 2021


On 6/14/2021 3:17 PM, Kulkarni, Vandita wrote:
>> -----Original Message-----
>> From: B S, Karthik <karthik.b.s at intel.com>
>> Sent: Monday, June 14, 2021 1:58 PM
>> To: igt-dev at lists.freedesktop.org
>> Cc: Kulkarni, Vandita <vandita.kulkarni at intel.com>; Joshi, Kunal1
>> <kunal1.joshi at intel.com>; B S, Karthik <karthik.b.s at intel.com>
>> Subject: [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output
>>
>> Use 'output' here rather than 'data->output' as it is still not populated.
>>
>> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/3494
> Fixes - patch that introduced this
> Closes - issue id
> With that fixed,
> LGTM.
> Reviewed-by: Vandita Kulkarni <vandita.kulkarni at intel.com>

Thank you for the rb. I will update the patch accordingly.

Thanks,

Karthik.B.S

>
> Thanks,
> Vandita
>> Signed-off-by: Karthik B S <karthik.b.s at intel.com>
>> ---
>>   tests/kms_dp_dsc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c index
>> 2446fd82..12180b19 100644
>> --- a/tests/kms_dp_dsc.c
>> +++ b/tests/kms_dp_dsc.c
>> @@ -228,7 +228,7 @@ static void run_test(data_t *data, igt_output_t
>> *output,  {
>>   	enum pipe pipe;
>>
>> -	data->mode = igt_output_get_mode(data->output);
>> +	data->mode = igt_output_get_mode(output);
>>   	igt_create_pattern_fb(data->drm_fd, data->mode->hdisplay,
>>   			      data->mode->vdisplay,
>>   			      DRM_FORMAT_XRGB8888,
>> --
>> 2.22.0




More information about the igt-dev mailing list