[igt-dev] [PATCH i-g-t 68/77] igt/dummyload: Require an intel_ctx_t for POLL_RUN and !ALL_ENGINES

Dixit, Ashutosh ashutosh.dixit at intel.com
Wed Jun 16 22:56:13 UTC 2021


On Wed, 16 Jun 2021 10:25:12 -0700, Jason Ekstrand wrote:
>
> I take that back.  Now I remember how these interact.  We need an
> intel_ctx_t for ALL_ENGINES so we can iterate over it.  We also need
> an intel_ctx_t for POLL_RUN so we can check
> gem_class_can_store_dword().  However, if you're using neither, we
> technically don't need an intel_ctx_t.  Does that make sense?

Yes, thanks. You are right, the code is correct, no changes needed. ctx_id
also survives and can be used when needed.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>


More information about the igt-dev mailing list