[igt-dev] [PATCH i-g-t 68/77] igt/dummyload: Require an intel_ctx_t for POLL_RUN and !ALL_ENGINES

[Petri Latvala]

On Wed, Jun 16, 2021 at 12:30:42PM -0500, Jason Ekstrand wrote:
> On Tue, Jun 15, 2021 at 9:56 PM Dixit, Ashutosh
> <ashutosh.dixit at intel.com> wrote:
> >
> > On Tue, 15 Jun 2021 19:49:14 -0700, Dixit, Ashutosh wrote:
> > >
> > > I have another related question/observation. If what I am saying above is
> > > indeed true, is the "ctx_id" field in "struct igt_spin_factory" ever
> > > really used? If not we should delete it from the struct and we can get rid
> > > of these asserts.
> > >
> > > This is because I am saying above that we have an igt_assert(opts->ctx)
> > > above in igt_spin_factory() when "opts->engine != ALL_ENGINES" and then we
> > > have another igt_assert(opts->ctx) in emit_recursive_batch() when
> > > "opts->engine == ALL_ENGINES". So it appears we must always have
> > > intel_ctx_t and can never use the "ctx_id" field in "struct
> > > igt_spin_factory" so it should be removed.
> > >
> > > So appears the spinner interface will always need a intel_ctx_t (meaning
> > > more code changes).
> >
> > Sorry for harping on this again. Note that even with the code in this
> > series test like igt at gem_ctx_exec@norecovery (which have not been modified)
> > should now be broken. The code in this series is:
> 
> Yup.  That was a miss.  Not sure why CI didn't catch it.

The reason is

tests/intel-ci/blacklist.txt:igt at gem_ctx_exec@(?!.*basic).*


-- 
Petri Latvala