[igt-dev] [PATCH i-g-t 62/77] tests/i915/gem_workarounds: Convert to intel_ctx_t

Jason Ekstrand jason at jlekstrand.net
Thu Jun 17 15:59:15 UTC 2021


On Wed, Jun 16, 2021 at 7:28 PM Dixit, Ashutosh
<ashutosh.dixit at intel.com> wrote:
>
> On Mon, 14 Jun 2021 09:38:47 -0700, Jason Ekstrand wrote:
> >
> > Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
>
> Just to make sure, this would have worked with the previous code too
> (i.e. without this patch), correct, using .ctx_id for igt_spin_new? What
> then is the reason for this patch, is it that intel_ctx_0 is preferred?

A context is required for SPIN_POLL_RUN.  We could, in theory, make
NULL work by just subbing in intel_ctx_0() but it's nicer to be
explicit when we can, IMO.

--Jason

> Anyway the patch is fine so:
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>


More information about the igt-dev mailing list