[igt-dev] [PATCH i-g-t 77/79] tests/i915/gem_ctx_engines: Fix the invalid subtest for the new rules

Dixit, Ashutosh ashutosh.dixit at intel.com
Wed Jun 23 00:04:36 UTC 2021


On Thu, 17 Jun 2021 12:15:14 -0700, Jason Ekstrand wrote:
>
> +	/* Reset back to a known-good param struct */
> +	param.size = sizeof(*engines) + sizeof(*engines->engines);
> +	param.value = to_user_pointer(engines);
> +	igt_assert_eq(__set_param_fresh_context(i915, param), 0);
> +
> +	/* Test that we can't set engines after we've done an execbuf */
> +	param.ctx_id = gem_context_create(i915);
> +	spin = igt_spin_new(i915, .ctx_id = param.ctx_id);
> +	igt_spin_free(i915, spin);
> +	igt_assert_eq(__gem_context_set_param(i915, &param), -EINVAL);
> +	gem_context_destroy(i915, param.ctx_id);
> +
> +	/* Test that we can't set engines on ctx0 */

Ah, didn't know this:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>

> +	param.ctx_id = 0;
> +	igt_assert_eq(__gem_context_set_param(i915, &param), -EINVAL);
> +
>  out:
>	munmap(engines, 4096);
> -	gem_context_destroy(i915, param.ctx_id);
>  }


More information about the igt-dev mailing list