[igt-dev] [PATCH i-g-t 75/79] tests/i915/gem_ctx_param: Add tests for recently removed params

[Dixit, Ashutosh]

On Thu, 17 Jun 2021 12:15:12 -0700, Jason Ekstrand wrote:
>

Please add SOB.

> @@ -406,6 +435,21 @@ igt_main
>		igt_assert_eq(__gem_context_set_param(fd, &arg), -EINVAL);
>	}
>
> +	igt_subtest("invalid-set-ringsize")
> +		test_set_invalid_param(fd, I915_CONTEXT_PARAM_RINGSIZE, 8192);
> +
> +	igt_subtest("invalid-get-ringsize")
> +		test_get_invalid_param(fd, I915_CONTEXT_PARAM_RINGSIZE);
> +
> +	igt_subtest("invalid-set-no-zeromap")
> +		test_set_invalid_param(fd, I915_CONTEXT_PARAM_NO_ZEROMAP, 1);
> +
> +	igt_subtest("invalid-get-no-zeromap")
> +		test_get_invalid_param(fd, I915_CONTEXT_PARAM_NO_ZEROMAP);
> +
> +	igt_subtest("invalid-get-engines")
> +		test_get_invalid_param(fd, I915_CONTEXT_PARAM_ENGINES);

Overall I'd have preferred that if we can set engines we should also be
able to get engines and a lot of these changes would have been avoided if
we had just been able to do that. The savings for removing get_engines are
also minimal. However since a decision somewhere seems to have been made to
remove get_engines this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>