[igt-dev] [PATCH i-g-t 48/79] tests/i915/gem_exec_balancer: Stop cloning engines

Dixit, Ashutosh ashutosh.dixit at intel.com
Fri Jun 25 22:26:16 UTC 2021


On Thu, 17 Jun 2021 12:12:55 -0700, Jason Ekstrand wrote:
>
> We have the list of engines and bonding info in each case.  Using clone
> is just being lazy for no good reason.

Clone was a valid API so can't call it lazy. Probably just say use the
engine list and bonding info instead of clone ;)

> @@ -2359,7 +2361,7 @@ static void waits(int i915, int timeout)
>		if (count > 1) {
>			uint32_t ctx = load_balancer_create(i915, ci, count);
>
> -			__waits(i915, timeout, ctx, count);
> +			__waits(i915, timeout, ci, count);
>
>			gem_context_destroy(i915, ctx);
>		}


Should delete the ctx create/destroy too but it's done in a later patch so
it's fine.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>


More information about the igt-dev mailing list