[igt-dev] [PATCH i-g-t 78/79] tests/i915/gem_exec_balancer: Fix invalid-balancer for the set-once rule

Jason Ekstrand jason at jlekstrand.net
Wed Jun 30 17:43:22 UTC 2021


On Fri, Jun 25, 2021 at 7:48 PM Dixit, Ashutosh
<ashutosh.dixit at intel.com> wrote:
>
> On Thu, 17 Jun 2021 12:15:15 -0700, Jason Ekstrand wrote:
> >
> > Upstream i915 is going to start only allowing CONTEXT_PARAM_ENGINES to
> > be set once on any given context.  This means we need to create a new
> > context for every setparam in the test.
>
> Will the previous code actually not work since we have not done any
> submission (I thought the context was mutable till the first submission)?

At Daniel's request, I changed it so you can set engines at most once.
It allows us to simplify the kernel code a bit.

> In any case the patch is fine, so this:
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>


More information about the igt-dev mailing list