[igt-dev] [PATCH i-g-t] lib/igt_edid: Allocate raw 8-bytes for VSDB

[Petri Latvala]

On Sun, Feb 28, 2021 at 12:03:22PM +0200, Martin Peres wrote:
> On 28/02/2021 00:10, Khem Raj wrote:
> > hdmi_vsdb is an element of cea_vsdb which makes the size of cea_vsdb to
> > be 8 ( 3bytes ieee_oui ) + ( 5bytes hdmi_vsdb struct), its true that we
> > only use 7 bytes technically we can only allocate 7byte array but since
> > we are writing to elements of hdmi_vsdb struct which is sitting at offet
> > 4-8 in cea_vsdb, compiler thinks we have an element which is out of
> > array bounds since out allocated size is 7bytes
> > 
> > This errors out
> > ../git/lib/igt_edid.c:365:13: error: array subscript 'struct hdmi_vsdb[0]' is partly outside array bounds of 'char[7]' [-Werror=array-bounds]
> >    365 |         hdmi->src_phy_addr[0] = 0x10;
> >        |             ^~
> > 
> > allocating one extra byte matches with size of cea_vsdb and compiler is
> > happy
> > 
> > Signed-off-by: Khem Raj <raj.khem at gmail.com>
> 
> Lookgs good to me, thanks!
> 
> Reviewed-by: Martin Peres <martin.peres at mupuf.org>


Merged, thanks.


-- 
Petri Latvala