[igt-dev] [PATCH i-g-t] lib/kmod: Stop producing results at all for kernel selftests on taint

Chris Wilson chris at chris-wilson.co.uk
Tue Mar 2 11:48:02 UTC 2021


Quoting Petri Latvala (2021-02-25 08:35:53)
> Instead of producing skips for the rest when one selftest taints the
> kernel, stop running them altogether. Having the skips produced yields
> no value and just makes future improvements (like correctly tagging
> tests that cause taints) harder. In effect, this gets us back to the
> old setup when tainting made igt_runner immediately kill the test and
> similarly made us not get spurious results for the rest of the
> selftests.

Skip isn't spurious here. I don't see how this impacts tagging the
earlier tests. So the only question for me is whether SKIP or NOTRUN is
more applicable. And skip is far more informative when run by hand...

Skip means the test exists (and under dynamic we presume applicable) but
could not be run due to an external event.

What improvement do we expect here? If it's just working around
mistaken cibuglog policy, then I don't see anything...
-Chris


More information about the igt-dev mailing list