[igt-dev] [PATCH i-g-t] tests/kms_3d: update stereo mode count static value

Matt Roper matthew.d.roper at intel.com
Wed Mar 3 17:45:06 UTC 2021


On Wed, Mar 03, 2021 at 07:05:01PM +0530, venkata.sai.patnana at intel.com wrote:
> From: Patnana Venkata Sai <venkata.sai.patnana at intel.com>
> 
> To set 3D mode, we need atleast one supported 3d mode is
> sufficient.

I'd suggest adding some clarification that some modes from the supplied
EDID may be pruned due to other platform limitations (e.g., restricted
link rates and such) which is why we wouldn't necessarily end up with
the full 13 on all platforms.

Aside from updating the commit message a bit, the code change is

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> 
> Cc: Matt Roper <matthew.d.roper at intel.com>
> Cc: Sharma Swati2 <swati2.sharma at intel.com>
> Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana at intel.com>
> ---
>  tests/kms_3d.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_3d.c b/tests/kms_3d.c
> index 2622b2d0a6..a88a86eea3 100644
> --- a/tests/kms_3d.c
> +++ b/tests/kms_3d.c
> @@ -69,7 +69,7 @@ igt_simple_main
>  			mode_count++;
>  	}
>  
> -	igt_assert_eq(mode_count, 13);
> +	igt_assert(mode_count);
>  
>  	/* set 3D modes */
>  	igt_info("Testing:\n");
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795


More information about the igt-dev mailing list