[igt-dev] [PATCH i-g-t v4] tests/kms_properties: Add subtest description

[Sharma, Swati2]

LGTM. Made alignment change while merging. Pushed changes.
Reviewed-by: Swati Sharma <swati2.sharma at intel.com>

On 05-Mar-21 1:11 PM, Arundhati Hagaragi wrote:
> Added description for all subtests
> 
> Signed-off-by: Arundhati Hagaragi <arundhati.hagaragi at intel.com>
> Cc: Sharma, Swati2 <swati2.sharma at intel.com>
> 
> v2, v3, v4: modified subtests description to be more specific. (swati)
> ---
>   tests/kms_properties.c | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> index b743f9d6..4be24a31 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -735,35 +735,51 @@ igt_main
>   		igt_display_require(&display, display.drm_fd);
>   	}
>   
> +	igt_describe("Tests plane properties with legacy commit");
>   	igt_subtest("plane-properties-legacy")
>   		plane_properties(&display, false);
>   
> +	igt_describe("Tests plane properties with atomic commit");
>   	igt_subtest("plane-properties-atomic")
>   		plane_properties(&display, true);
>   
> +	igt_describe("Tests crtc properties with legacy commit");
>   	igt_subtest("crtc-properties-legacy")
>   		crtc_properties(&display, false);
>   
> +	igt_describe("Tests crtc properties with atomic commit");
>   	igt_subtest("crtc-properties-atomic")
>   		crtc_properties(&display, true);
>   
> +	igt_describe("Tests connector properties with legacy commit");
>   	igt_subtest("connector-properties-legacy")
>   		connector_properties(&display, false);
>   
> +	igt_describe("Tests connector properties with atomic commit");
>   	igt_subtest("connector-properties-atomic")
>   		connector_properties(&display, true);
>   
> +	igt_describe("Checks each property of any type with combination of mode object with legacy "
> +			"commit and make sure only valid properties are set to mode object else "
> +			"return with relevant error");
> +
>   	igt_subtest("invalid-properties-legacy")
>   		invalid_properties(&display, false);
>   
> +	igt_describe("Checks each property of any type with combination of mode object with atomic "
> +			"commit and make sure only valid properties are set to mode object else "
> +			"return with relevant error");
> +
>   	igt_subtest("invalid-properties-atomic")
>   		invalid_properties(&display, true);
>   
> +	igt_describe("Test validates the properties of all planes, crtc and connectors with atomic commit");
>   	igt_subtest("get_properties-sanity-atomic") {
>   		igt_skip_on(!display.is_atomic);
>   		get_prop_sanity(&display, true);
>   	}
>   
> +	igt_describe("Test validates the properties of all planes, crtc and connectors with legacy commit");
>   	igt_subtest("get_properties-sanity-non-atomic") {
>   		if (display.is_atomic)
>   			igt_assert_eq(drmSetClientCap(display.drm_fd, DRM_CLIENT_CAP_ATOMIC, 0), 0);
> 

-- 
~Swati Sharma