[igt-dev] [PATCH i-g-t v21 17/35] lib/intel_batchbuffer: Add tracking intel_buf to intel_bb

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 5 14:33:14 UTC 2021


Quoting Zbigniew Kempczyński (2021-03-01 16:13:45)
> +void intel_bb_intel_buf_list(struct intel_bb *ibb)
> +{
> +       struct intel_buf *entry;
> +
> +       igt_list_for_each_entry(entry, &ibb->intel_bufs, link) {
> +               igt_info("handle: %u, ibb: %p, offset: %lx\n",
> +                        entry->handle, entry->ibb,
> +                        (long) entry->addr.offset);
> +       }
> +}

An unconventional use of "list" in intel_buf_list(). Normally we would
expect that to describe either the list or a function that returns
the list of bufs. intel_bb_print_bufs() would be clearer.
-Chris


More information about the igt-dev mailing list