[igt-dev] [PATCH i-g-t v2 2/2] kms_hdr: Fix bpc-switch tests on AMD hardware

Kazlauskas, Nicholas nicholas.kazlauskas at amd.com
Fri Mar 5 16:48:04 UTC 2021


On 2021-03-05 11:42 a.m., Jeremy Cline wrote:
> Kernel commit b836a274b797 ("drm/amdgpu/dc: Require primary plane to be
> enabled whenever the CRTC is") causes the bpc-switch tests to fail,
> since the primary plane fb is being removed, which leads to the next
> atomic commit failing with -EINVAL.
> 
> This stops the removal of the primary plane fb before switching to 10
> bits per component and the test now runs successfully.
> 
> Signed-off-by: Jeremy Cline <jcline at redhat.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>

You'll want to ping someone from Intel or the IGT maintainers for patch 
1 in the series, however.

Regards,
Nicholas Kazlauskas

> ---
>   tests/kms_hdr.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
> index 7617e8a5..8aa3ea78 100644
> --- a/tests/kms_hdr.c
> +++ b/tests/kms_hdr.c
> @@ -223,8 +223,6 @@ static void test_bpc_switch_on_output(data_t *data, igt_output_t *output,
>   			data->h = afb.height;
>   		}
>   
> -		igt_plane_set_fb(data->primary, NULL);
> -
>   		/*
>   		 * i915 driver doesn't expose max bpc as debugfs entry,
>   		 * so limiting assert only for amd driver.
> 



More information about the igt-dev mailing list