[igt-dev] [PATCH i-g-t v2 1/2] kms_hdr: Skip HDR tests on pre-Kaby Lake Intel devices

[Petri Latvala]

On Fri, Mar 05, 2021 at 11:42:52AM -0500, Jeremy Cline wrote:
> According to the Intel documentation[0] I could find, HDR support is
> only in Kaby Lake+. Skip tests in kms_hdr if the hardware doesn't
> support HDR.
> 
> [0] https://www.intel.com/content/dam/support/us/en/documents/graphics/HDR_Intel_Graphics_TechWhitePaper.pdf
> 
> Signed-off-by: Jeremy Cline <jcline at redhat.com>


While that might be true, strictly speaking IGT tests are not testing
the HW capabilities but the kernel interfaces. The difference is often
only interesting for nitpicking.

However, in this case a good argument can be made either way, with
what the correct behaviour with setting the "max bpc" property when
the HW doesn't support HDR _output_ should be. IGT tests should be
written the way one would expect "real" userspace to behave; does the
documented kernel interface require userspace to detect the device id
somehow? The connector property is there so one would assume setting
it should work and do something.

A good argument can also be made that even though we're testing "just
the interface", we (Intel) should have a separate test that requires
actual HW support...

Swati, Maarten, thoughts on this? Are we even testing the right things
for i915 at all? Are we able to express the HW requirement for HDR
with something other than comparing devid? Should we? (If we should
not, please suggest a better way to get around the issue being fixed
here)


-- 
Petri Latvala




> ---
>  tests/kms_hdr.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
> index e9dd7f27..7617e8a5 100644
> --- a/tests/kms_hdr.c
> +++ b/tests/kms_hdr.c
> @@ -644,6 +644,12 @@ igt_main
>  		igt_require(data.display.is_atomic);
>  
>  		igt_display_require_output(&data.display);
> +
> +		/* According to Intel documentation, hardware prior to Kaby Lake does
> +		 * not support HDR.
> +		 */
> +		if (is_i915_device(data.fd))
> +			igt_require(AT_LEAST_GEN(intel_get_drm_devid(data.fd), 9));
>  	}
>  
>  	igt_describe("Tests switching between different display output bpc modes");
> -- 
> 2.30.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev