[igt-dev] [PATCH i-g-t v21 19/35] tests/api_intel_bb: Modify test to verify intel_bb with allocator

[Chris Wilson]

Quoting Zbigniew Kempczyński (2021-03-08 09:47:56)
> On Fri, Mar 05, 2021 at 02:39:58PM +0000, Chris Wilson wrote:
> > Quoting Zbigniew Kempczyński (2021-03-01 16:13:47)
> > >         intel_bb_emit_bbe(ibb);
> > > -       igt_debug("exec flags: %" PRIX64 "\n", flags);
> > > -       intel_bb_exec(ibb, intel_bb_offset(ibb), flags, true);
> > > +       intel_bb_flush_blit(ibb);
> > > +       intel_bb_sync(ibb);
> > 
> > Hmm. That does remind me, I haven't seen EXEC_OBJECT_WRITE being set.
> > -Chris
> 
> 
> In __emit_blit() -> intel_bb_emit_blt_copy() we add dst as target:
> 
> ...
>         intel_bb_add_intel_buf(ibb, src, false);
>         intel_bb_add_intel_buf(ibb, dst, true);
> ...

So the sync is because? Everytime I see an implicit sync the implication
is that it is covering over a bug.
-Chris