[igt-dev] [PATCH i-g-t v8] tests/kms_plane_scaling: Add plane scaling test descriptions for subtests

[Khajapasha, Mohammed]

> -----Original Message-----
> From: Hagaragi, Arundhati <arundhati.hagaragi at intel.com>
> Sent: Tuesday, March 9, 2021 5:00 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Gupta, Nidhi1 <nidhi1.gupta at intel.com>; Khajapasha, Mohammed
> <mohammed.khajapasha at intel.com>
> Subject: [PATCH i-g-t v8] tests/kms_plane_scaling: Add plane scaling test
> descriptions for subtests
> 
> From: Nidhi Gupta <nidhi1.gupta at intel.com>
> 
> Add plane scaling test descriptions for subtests.
> Plane scaling with tiling rotation, pixel formats, overlay planes and with
> clipping and clamping
> 
> Signed-off-by: Nidhi Gupta <nidhi1.gupta at intel.com>
> Cc: Khajapasha Mohammed <mohammed.khajapasha at intel.com>
> 
> v1-v8 : Review Comments (Khaja)
> ---
>  tests/kms_plane_scaling.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c index
> c63eb428..b0d4dcf6 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -695,32 +695,38 @@ igt_main_args("", long_opts, help_str,
> opt_handler, &data)
>  		igt_output_t *output;
> 
>  		igt_subtest_with_dynamic("plane-scaling") {
> +			igt_describe("Test plane scaling with overlay
> planes");
>  			for_each_pipe_with_single_output(&data.display,
> pipe, output)
>  				igt_dynamic_f("pipe-%s-plane-scaling",
> kmstest_pipe_name(pipe))
>  					test_plane_scaling_on_pipe(&data,
> pipe, output);
>  		}
> 
>  		igt_subtest_with_dynamic("scaler-with-pixel-format") {
> +			igt_describe("Test plane scaling with pixel formats");
>  			for_each_pipe_with_single_output(&data.display,
> pipe, output)
>  				igt_dynamic_f("pipe-%s-scaler-with-pixel-
> format", kmstest_pipe_name(pipe))
> 
> 	test_scaler_with_pixel_format_pipe(&data, pipe, output);
>  		}
> 
>  		igt_subtest_with_dynamic("scaler-with-rotation") {
> +			igt_describe("Test plane scaling with rotation");
>  			for_each_pipe_with_single_output(&data.display,
> pipe, output)
>  				igt_dynamic_f("pipe-%s-scaler-with-
> rotation", kmstest_pipe_name(pipe))
> 
> 	test_scaler_with_rotation_pipe(&data, pipe, output);
>  		}
> 
>  		igt_subtest_with_dynamic("scaler-with-clipping-clamping") {
> +			igt_describe("Test plane scaling with  clipping-
> clamping");
>  			for_each_pipe_with_single_output(&data.display,
> pipe, output)
>  				igt_dynamic_f("pipe-%s-scaler-with-clipping-
> clamping", kmstest_pipe_name(pipe))
> 
> 	test_scaler_with_clipping_clamping_scenario(&data, pipe, output);
>  		}
>  	}
> 
> -	igt_subtest_f("2x-scaler-multi-pipe")
> +	igt_subtest_f("2x-scaler-multi-pipe") {
> +		igt_describe("Test to display planes on connected pipes and
> runs
> +scaling test on it");

"Test multi plane scaling with connected outputs for pipes"
test_scaler_with_multi_pipe_plane() runs the plane scaling for pipes which are connected with an output,
and creates the framebuffers for each plane of pipe and runs scaling with connector mode.

With said: Reviewed-by: Khajapasha, Mohammed <mohammed.khajapasha at intel.com>

>  		test_scaler_with_multi_pipe_plane(&data);
> +	}
> 
>  	igt_fixture
>  		igt_display_fini(&data.display);


> --
> 2.25.1